Add restriction for enabling limit pruning #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some tests are failed, i am not sure if it's related: failures:
parquet::row_group_pruning::test_limit_pruning_basic
parquet::row_group_pruning::test_limit_pruning_complex_filter
parquet::row_group_pruning::test_limit_pruning_multiple_fully_matched |
Collaborator
Author
Yeah, I'm fixing it |
Collaborator
Author
DF doesn't support limit pushdown filter in logical optimizer now, even if the pushdown_filter is true. I disabled these failed tests and plan to merge the PR so as not to block the upgrade DF51. |
xudong963
added a commit
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should do some restrictions for limit pruning. Only the pure limit query can be pruned by limit.